Re: Re: unixODBC again :-(

Peter Eisentraut <peter_e@gmx.net>

From: Peter Eisentraut <peter_e@gmx.net>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Nick Gorham <nick@lurcher.org>, PostgreSQL-development <pgsql-hackers@postgreSQL.org>, PostgreSQL odbc list <pgsql-odbc@postgreSQL.org>
Date: 2001-01-24T18:15:12Z
Lists: pgsql-hackers
Bruce Momjian writes:

> > 1. Add options to use unixODBC in the configure.in file, the mainly consists of finding the root of the unixODBC install prefix, and adding
> > -I /unixODBC/path/include and -L /unixODBC/path/lib to the driver build

--with-includes, --with-libraries

> > 2. Change the way the driver gets config info, to be the same as when built under windows. link with -lodbcinst and it provides
> > SQLGetPrivateProfileString. the code that calls this works as long as the correct define is set.

I don't understand this.  The driver gets the config info just fine; why
add another way?

> > 3. Stop calling ODBC functions in the driver, this is simple but messy, the problem being the call (say) in SQLAllocStmt that calls
> > SQLAllocHandle in the driver, ends up calling the SQLAllocHandle in the driver manager.

This is fixed using magic linker options on ELF platforms.  I don't recall
how the patch tried to address this, but a better solution is probably
necessary.

> > There are a couple of other changes I have made, that you may want
> to add, I added the code to allow encrypted passwords (taken from the
> pg > lib), as crypt is avaiable on unix.

Why not.

> Add the option to detect a
> server name of localhost, and open the unix domain socket,

I don't think so.  localhost is a valid host name.

> in fact try
> two > places, to handle the debian build where the location is
> different.

We have a general approach to non-standard socket names now.

-- 
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/