Re: Use of 'cp -r' in CREATE DATABASE
Nigel J. Andrews <nandrews@investsystems.co.uk>
From: "Nigel J. Andrews" <nandrews@investsystems.co.uk>
To: Alvaro Herrera <alvherre@dcc.uchile.cl>
Cc: Bruce Momjian <pgman@candle.pha.pa.us>, PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Date: 2003-12-12T00:45:21Z
Lists: pgsql-hackers
On Thu, 11 Dec 2003, Alvaro Herrera wrote: > On Thu, Dec 11, 2003 at 06:36:05PM -0500, Bruce Momjian wrote: > > Our dbcommands.c has for create database: > > > > snprintf(buf, sizeof(buf), "cp -r '%s' '%s'", src_loc, target_dir); > > > [...] > > > > I think we should switch to -R in our code. > > But you will have to write special code for Win32, won't you? > Maybe it would be better to avoid using system commands > altogether and copy the whole thing using syscalls ... That was my immediate thought. Unfortunately that means reinventing the wheel; or grabbing it from BSD or somewhere and distributing it with postgresql. -- Nigel J. Andrews