Re: A Sparc/Linux patch (for 7.1), and a Linux rc.d/init.d script....

Ryan Kirkpatrick <pgsql@rkirkpat.net>

From: Ryan Kirkpatrick <pgsql@rkirkpat.net>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: pgsql-patches@postgresql.org
Date: 2001-01-31T03:01:02Z
Lists: pgsql-hackers

Attachments

On Tue, 30 Jan 2001, Bruce Momjian wrote:

> > 	postgres-7-sparc.patch -> This is the same one I posted earlier to
> > hackers and ports, forgot to post it to patches. This fixes the resultmap
> > for sparc-linux so that all regression tests pass.
> 
> Already applied.

	Great! Just never saw a confirmation (may have missed it) of my
first post. Also verified it is in beta4, and all regression
tests now pass on Sparc/Linux. :)

> > 	postgresql -> This is a Linux distribution independent (or so I
> > hope) init.d/rc.d script that makes use of pg_ctl. There is currently a
> > few in ./contrib/linux of the pgsql source tree, but they are RedHat
> > specific. This one is simple and self contained. Might be worth adding to
> > the other scripts. 
>
> Added to /contrib as init.d. 

	Please replace with the one attached to this email message. The
previous version depended on the below patch, this one does not. It is
also a bit cleaner and has a few more helpful comments. 

> > 	pg_ctl.patch -> Minor patch required by postgresql script above.
> > It basically just allows you to specify the -o option (postmaster options)
> > more than once and all of them will be concatenated together. Makes it
> > easier to do '-o -F -o -i', then to try and shell escape quotes in a shell
> > script. Should be harmless, and might be handy. 
> 
> This doesn't seem like a good idea.  It makes -o handling different for
> different utilities.

	Hmm... Didn't know other utils used that option. Maybe use the
'--' option for pg_ctl passing postmaster options, i.e. 'pg_ctl start --
-F -i'. Of course that is a bit more major of a change to the code that I
will leave as an exercise to others. With the revised version of the
init.d script attached, the pg_ctl patch is immaterial.
	Thanks and TTYL.

---------------------------------------------------------------------------
|   "For to me to live is Christ, and to die is gain."                    |
|                                            --- Philippians 1:21 (KJV)   |
---------------------------------------------------------------------------
|   Ryan Kirkpatrick  |  Boulder, Colorado  |  http://www.rkirkpat.net/   |
---------------------------------------------------------------------------