Thread

  1. Re: btree_gist (was: CommitFest progress - or lack thereof)

    Oleg Bartunov <oleg@sai.msu.su> — 2011-02-12T08:39:01Z

    Stephen,
    
    what do you need for documentation ? From users point of view we add just
    knn support and all examples are available in btree_gist.sql and sql 
    subdirectory. Contact me directly, if you have questions.
    
    Oleg
    On Fri, 11 Feb 2011, Stephen Frost wrote:
    
    > * Robert Haas (robertmhaas@gmail.com) wrote:
    >>> Teodor sent it to the list Dec 28, see
    >>> http://archives.postgresql.org/message-id/4D1A1677.80300%40sigaev.ru
    > [...]
    >> That having been said, this looks like a fairly mechanical change to a
    >> contrib module that you and Teodor wrote.  So I'd say if you guys are
    >> confident that it's correct, go ahead and commit.  If you need it
    >> reviewed, or if you can't commit it in the next week or so, I think
    >> it's going to have to wait for 9.2.
    >
    > Alright, I've gone through this patch and the main thing it's missing is
    > documentation, as far as I can tell.  It passes all the regression tests
    > (and adds a number of them which are then tested with, which is always
    > nice) and while there are quite a few changes, they're all pretty
    > mechanical and simple.  There are some really minor whitespace issues
    > too, but overall I think this is ready to be committed, so long as we
    > have a promise that someone will write up the documentation for it.
    >
    > I'd write the docs, but I'm not 100% sure that I know what's going on
    > enough to really write them correctly. :)  I'm also hoping that someone
    > else is already working on them.  If not, feel free to ping me and I'll
    > work on writing up *something*, at least.
    >
    > 	Thanks,
    >
    > 		Stephen
    >
    
     	Regards,
     		Oleg
    _____________________________________________________________
    Oleg Bartunov, Research Scientist, Head of AstroNet (www.astronet.ru),
    Sternberg Astronomical Institute, Moscow University, Russia
    Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
    phone: +007(495)939-16-83, +007(495)939-23-83