Thread

1. Re: [HACKERS] BIG grant problem

   Tom Lane <tgl@sss.pgh.pa.us> — 1998-11-15T06:31:42Z

   Bruce Momjian <maillist@candle.pha.pa.us> writes:
   > Terry Mackintosh wrote:
   >> Minor detail, but when I did 'pg_dump -z -f dump.file dbname' and then
   >> went to restore it, I found that the grant statments are like:
   >> GRANT ALL on "tablename" to "tablename";
   >> instead of
   >> GRANT ALL on "tablename" to "username";
   
   > Yikes, confirmed here.  We need to know how this got into the tree
   > without showing up on our tests,
   
   Well, that's easy --- there are no regression tests that test pg_dump
   at all, nor any that test multiple table owners and permissions.
   
   FWIW, pg_dump -z works correctly for GRANT to PUBLIC --- otherwise
   I would've noticed some time ago.  But I hadn't had occasion
   to check granting permission to specific users :-( ... and I don't
   think most of the rest of the developers work with databases that
   even have multiple users, let alone put access restrictions on
   individual tables.
   
   It's certainly true that pg_dump is pretty weak in the area of
   table ownerships and permissions.  We have fixed several bugs
   in that area since 6.3.2, and I'm not particularly surprised to
   hear of another one.  We need someone who actually has occasion
   to work with access-restricted databases to pound on pg_dump for
   a while and flush out the bugs.  (Terry, can you volunteer?)
   I don't think the bugs will be hard to fix, it's just a matter
   of not having done enough testing.
   
   			regards, tom lane
   
   

2. Re: [HACKERS] BIG grant problem

   Terry Mackintosh <terry@terrym.com> — 1998-11-15T13:13:29Z

   Hi
   
   On Sun, 15 Nov 1998, Tom Lane wrote:
   
   > hear of another one.  We need someone who actually has occasion
   > to work with access-restricted databases to pound on pg_dump for
   > a while and flush out the bugs.  (Terry, can you volunteer?)
   
   Sure.
   
   > I don't think the bugs will be hard to fix, it's just a matter
   > of not having done enough testing.
   
   I started to look at it last night, found where the line is created in the
   pg_dump.c file, looks ok there, so the problem is a little deeper then
   just an easy typo.
   
   Should be able to look at it today.
   
   Have a great day
   Terry Mackintosh <terry@terrym.com>          http://www.terrym.com
   sysadmin/owner  Please! No MIME encoded or HTML mail, unless needed.
   
   Proudly powered by R H Linux 4.2, Apache 1.3, PHP 3, PostgreSQL 6.3
   -------------------------------------------------------------------
   Success Is A Choice ... book by Rick Patino, get it, read it!