Thread
Commits
-
Minor code beautification in regexp.c.
- 0db7c6705180 13.0 landed
-
Avoid quadratic slowdown in regexp match/split functions.
- c8ea87e4bd95 12.0 cited
-
Code cleanup for build_regexp_split_result
Japin Li <japinli@hotmail.com> — 2020-01-16T15:18:43Z
Hi hackers, I find the build_regexp_split_result() has redundant codes, we can move it to before the condition check, can we? Best regards. Japin Li
-
Re: Code cleanup for build_regexp_split_result
Tom Lane <tgl@sss.pgh.pa.us> — 2020-01-16T16:33:44Z
Li Japin <japinli@hotmail.com> writes: > I find the build_regexp_split_result() has redundant codes, we can move it to before the condition check, can we? Hm, yeah, that looks a bit strange. It was less strange before c8ea87e4bd950572cba4575e9a62284cebf85ac5, I think. Pushed with some additional simplification to get rid of the rather ugly (IMO) PG_USED_FOR_ASSERTS_ONLY variable. regards, tom lane