RE: Use attribute((target(sse4.2))) for SSE42 CRC32C

Devulapalli, Raghuveer <raghuveer.devulapalli@intel.com>

View thread View on postgr.es

From: "Devulapalli, Raghuveer" <raghuveer.devulapalli@intel.com>

To: Nathan Bossart <nathandbossart@gmail.com>

Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2024-11-07T21:42:58Z

Lists: pgsql-hackers

Attachments

v2-0001-Use-__attribute__-target-sse4.2-for-SSE42-CRC32C.patch (application/octet-stream) patch v2-0001

Here is the updated patch with the #if defined(__has_attribute) && __has_attribute (target) guard. 

> Oh, you are right, sorry.

No worries! 😊

> Is the idea that we will put both "choose" functions in one file and the actual
> CRC-32C code in another?  I'm okay with that.

Yup, there can only be one choose function that has to pick between avx512, sse42 and scalar code. 

Raghuveer

Commits

Use __attribute__((target(...))) for SSE4.2 CRC-32C support.
- 4b03a27fafc9 18.0 landed
Move check for USE_AVX512_POPCNT_WITH_RUNTIME_CHECK.
- 4225276e2540 18.0 landed
Remove MSVC scripts
- 1301c80b2167 17.0 cited