RE: Use attribute((target(sse4.2))) for SSE42 CRC32C

Devulapalli, Raghuveer <raghuveer.devulapalli@intel.com>

From: "Devulapalli, Raghuveer" <raghuveer.devulapalli@intel.com>

To: Nathan Bossart <nathandbossart@gmail.com>

Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "Shankaran, Akash" <akash.shankaran@intel.com>

Date: 2024-11-21T23:07:59Z

Lists: pgsql-hackers

Attachments

v4-0001-Use-__attribute__-target-sse4.2-for-SSE42-CRC32C.patch (application/octet-stream) patch v4-0001
v4-0002-Use-consistent-logic-in-configure-and-meson-to-ge.patch (application/octet-stream) patch v4-0002

> I think it is in pretty good shape.  After a read-through, the only thing that stands
> out to me is the difference in configure tests between autoconf and meson.  I
> think we should consider picking one approach, although I'm not sure I have a
> strong preference.

Thanks for the review! We can actually leverage meson's built in option to check for a macro: cc.get_define('__SSE4_2__') != ''. This should keep the logic consistent across configure and meson.

Commits

Use __attribute__((target(...))) for SSE4.2 CRC-32C support.
- 4b03a27fafc9 18.0 landed
Move check for USE_AVX512_POPCNT_WITH_RUNTIME_CHECK.
- 4225276e2540 18.0 landed
Remove MSVC scripts
- 1301c80b2167 17.0 cited