Horton

Re: Inconsistent LSN format in pg_waldump output

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Michael Paquier <michael@paquier.xyz>, Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-04T02:32:20Z
Lists: pgsql-hackers

Attachments

On Thu, 03 Jul 2025 at 18:07, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> On 2025-Jul-03, Japin Li wrote:
>
>> Providing two LSN formats — %X%08X for translatable messages and
>> LSN_FORMAT for non-translatable ones — seems to offer no clear advantage.
>> 
>> I'd prefer to use %X/%08X directly and add the description to the
>> LSN_FORMAT_ARGS macro.
>
> WFM.
>

Many thanks! V4 of the patch is now attached.

I've opted to directly use %X/%08X for LSN formatting in this patch, with an
accompanying comment near LSN_FORMAT_ARGS.

-- 
Regards,
Japin Li

Commits

  1. Fix a couple more places in docs for pg_lsn change

  2. Adapt pg_upgrade test to pg_lsn output format difference

  3. Standardize LSN formatting by zero padding