[PATCH] Fix references in comments, and sync up heap_page_is_all_visible() with heap_page_prune_and_freeze()

Greg Burd <greg@burd.me>

From: Gregory Burd <greg@burd.me>

To: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2025-05-06T15:39:07Z

Lists: pgsql-hackers

Attachments

v1-0001-Fix-references-in-comments-in-heap_page_is_all_vi.patch (application/octet-stream) patch v1-0001
v1-0003-Move-ItemPointerSet-call-to-better-match-heap_pag.patch (application/octet-stream) patch v1-0003
v1-0002-Reverse-loop-to-match-counterpart-and-optimize-fo.patch (application/octet-stream) patch v1-0002

While working on [1] I found an outdated comment in heap_page_is_all_visible() and two other small fixes.

0001: Updates that comment so future authors know that this "stripped down function" should retain the logic in heap_page_prune_and_freeze(), not lazy_scan_prune() as was the case before 6dbb490.
0002: Mimics the same loop logic as in heap_page_is_all_visible() so as to a) stay in sync and b) benefit from the mentioned CPU prefetching optimization.
0003: Moves the ItemSetPointer() just a bit further down in the function again to a) stay in sync and b) to sometimes avoid that tiny overhead.

best,

-greg

PS: per-community standards I've switched to my personal email address rather than gregburd@amazon.com

[1] https://www.postgresql.org/message-id/flat/78574B24-BE0A-42C5-8075-3FA9FA63B8FC@amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Combine freezing and pruning steps in VACUUM
- 6dbb490261a6 17.0 cited