Horton

Re: Typo in pg_db_role_setting.h

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Richard Guo <guofenglinux@gmail.com>, John Naylor <john.naylor@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-02T07:58:40Z
Lists: pgsql-hackers 
On Tue, 02 Aug 2022 at 15:45, Daniel Gustafsson <daniel@yesql.se> wrote:
>> On 2 Aug 2022, at 09:37, Richard Guo <guofenglinux@gmail.com> wrote:
>
>> The examples listed upthread all contain such comment in foo.h saying
>> 'prototypes for functions in foo.c'.  For instance, in buffile.h, there is
>> comment saying
>
>> /*
>>  * prototypes for functions in buffile.c
>>  */
>> 
>> So if we remove such comments, should we also do so for those cases?
>
> Comments which state the obvious are seldom helpful, I would prefer to remove
> such comments and only explicitly call out the .c file in a comment when it's a
> different basename from the header.

+1

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

Commits

  1. Fix comment in pg_db_role_setting.h