Re: Typo in pg_db_role_setting.h
Japin Li <japinli@hotmail.com>
From: Japin Li <japinli@hotmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@enterprisedb.com>,
"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-01T14:42:22Z
Lists: pgsql-hackers
Attachments
- remove-comments-about-prototypes-for-functions.patch (text/x-patch) patch
On Mon, 01 Aug 2022 at 22:16, Tom Lane <tgl@sss.pgh.pa.us> wrote: > John Naylor <john.naylor@enterprisedb.com> writes: >> You are correct, but I wonder if it'd be better to just drop the comment >> entirely. I checked a couple other random headers with function >> declarations and they didn't have such a comment, and it's kind of obvious >> what they're for. > > Some places have these, some don't. It's probably more useful where > a header foo.h is declaring functions that aren't in the obviously > corresponding foo.c file, or live in multiple files. In this case > I agree it's not adding much. > Attached patch to remove this comment. Please take a look. -- Regrads, Japin Li. ChengDu WenWu Information Technology Co.,Ltd.
Commits
-
Fix comment in pg_db_role_setting.h
- c689baa158bb 16.0 landed