Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Japin Li <japinli@hotmail.com>
From: Japin Li <japinli@hotmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Masahiko Sawada
<sawada.mshk@gmail.com>, PostgreSQL Hackers
<pgsql-hackers@lists.postgresql.org>
Date: 2023-06-14T13:42:37Z
Lists: pgsql-hackers
On Wed, 14 Jun 2023 at 17:52, Richard Guo <guofenglinux@gmail.com> wrote: > On Wed, Jun 14, 2023 at 3:47 PM Michael Paquier <michael@paquier.xyz> wrote: > >> On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote: >> > +1. BTW, it seems that GUC_UNIT_TIME is not used anywhere except in >> > GUC_UNIT. I was wondering if we can retire it, but maybe we'd better >> > not. It still indicates that we need to use time units table. >> >> Some out-of-core code declaring custom GUCs could rely on that, so >> it is better not to remove it. > > > I see. Thanks for pointing that out. > Thanks for all of your reviews. Agreed with Michael do not touch GUC_UNIT_TIME. -- Regrads, Japin Li.
Commits
-
Replace GUC_UNIT_MEMORY|GUC_UNIT_TIME with GUC_UNIT.
- a54fc892ad0a 16.0 landed