Horton

Thread

Commits

  1. Fix typos referring to PGPROC

  1. Typo in xact.c

    Japin Li <japinli@hotmail.com> — 2022-09-15T14:38:01Z

    Hi hacker,

Recently, I find there might be a typo in xact.c comments.  The comments
say "PG_PROC", however, it actually means "PGPROC" structure.  Since we
have pg_proc catalog, and use PG_PROC to reference the catalog [1], so,
we should use PGPROC to reference the structure.  Any thoughts?

[1] src/include/nodes/primnodes.h

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

  2. Re: Typo in xact.c

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-09-16T03:11:35Z

    At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li <japinli@hotmail.com> wrote in 
> 
> Hi hacker,
> 
> Recently, I find there might be a typo in xact.c comments.  The comments
> say "PG_PROC", however, it actually means "PGPROC" structure.  Since we
> have pg_proc catalog, and use PG_PROC to reference the catalog [1], so,
> we should use PGPROC to reference the structure.  Any thoughts?
> 
> [1] src/include/nodes/primnodes.h

The patch seems to me covering all occurances of PG_PROC as PGPROC.

I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is
quite confusing, too..

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  3. Re: Typo in xact.c

    John Naylor <john.naylor@enterprisedb.com> — 2022-09-16T03:51:32Z

    On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li <japinli@hotmail.com> wrote in
> >
> > Hi hacker,
> >
> > Recently, I find there might be a typo in xact.c comments.  The comments
> > say "PG_PROC", however, it actually means "PGPROC" structure.  Since we
> > have pg_proc catalog, and use PG_PROC to reference the catalog [1], so,
> > we should use PGPROC to reference the structure.  Any thoughts?
> >
> > [1] src/include/nodes/primnodes.h
>
> The patch seems to me covering all occurances of PG_PROC as PGPROC.

+1 since this hinders grep-ability.

> I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is
> quite confusing, too..

It's pretty obvious to me what that refers to in primnodes.h, although
the capitalization of (some, but not all) catalog names in comments in
that file is a bit strange. Maybe not worth changing there.

-- 
John Naylor
EDB: http://www.enterprisedb.com

  4. Re: Typo in xact.c

    Japin Li <japinli@hotmail.com> — 2022-09-16T03:57:34Z

    On Fri, 16 Sep 2022 at 11:51, John Naylor <john.naylor@enterprisedb.com> wrote:
> On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
>>
>> At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li <japinli@hotmail.com> wrote in
>> >
>> > Hi hacker,
>> >
>> > Recently, I find there might be a typo in xact.c comments.  The comments
>> > say "PG_PROC", however, it actually means "PGPROC" structure.  Since we
>> > have pg_proc catalog, and use PG_PROC to reference the catalog [1], so,
>> > we should use PGPROC to reference the structure.  Any thoughts?
>> >
>> > [1] src/include/nodes/primnodes.h
>>
>> The patch seems to me covering all occurances of PG_PROC as PGPROC.
>
> +1 since this hinders grep-ability.
>
>> I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is
>> quite confusing, too..
>
> It's pretty obvious to me what that refers to in primnodes.h, although
> the capitalization of (some, but not all) catalog names in comments in
> that file is a bit strange. Maybe not worth changing there.

Thanks for the review.  I found for system catalog, we often use lower case.
Here attached a new patch to fix it.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

  5. Re: Typo in xact.c

    Japin Li <japinli@hotmail.com> — 2022-09-16T04:01:46Z

    On Fri, 16 Sep 2022 at 11:11, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
> At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li <japinli@hotmail.com> wrote in 
>> 
>> Hi hacker,
>> 
>> Recently, I find there might be a typo in xact.c comments.  The comments
>> say "PG_PROC", however, it actually means "PGPROC" structure.  Since we
>> have pg_proc catalog, and use PG_PROC to reference the catalog [1], so,
>> we should use PGPROC to reference the structure.  Any thoughts?
>> 
>> [1] src/include/nodes/primnodes.h
>
> The patch seems to me covering all occurances of PG_PROC as PGPROC.
>
> I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is
> quite confusing, too..
>
> regards.

Thanks for the review.  Attached a new patch to replace upper case system
catatlog to lower case [1].

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

  6. Re: Typo in xact.c

    John Naylor <john.naylor@enterprisedb.com> — 2022-09-19T04:42:39Z

    On Fri, Sep 16, 2022 at 10:51 AM John Naylor
<john.naylor@enterprisedb.com> wrote:
>
> On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
> >
> > The patch seems to me covering all occurances of PG_PROC as PGPROC.
>
> +1 since this hinders grep-ability.

Pushed this.

> > I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is
> > quite confusing, too..
>
> It's pretty obvious to me what that refers to in primnodes.h, although
> the capitalization of (some, but not all) catalog names in comments in
> that file is a bit strange. Maybe not worth changing there.

I left this alone. It's not wrong, and I don't think it's confusing in context.

-- 
John Naylor
EDB: http://www.enterprisedb.com