Thread

Commits

Fix typo in reference to __FreeBSD__.
- e52f8b301ed5 16.0 landed
Produce compiler errors if errno is referenced inside elog/ereport calls.
- a2a8acd15217 12.0 cited

Typo macro name on FreeBSD?

Japin Li <japinli@hotmail.com> — 2022-12-16T03:43:36Z

Hi, hackers

Recently, I compile PostgreSQL on FreeBSD, I find commit a2a8acd152 introduecs
__freebsd__ macro, however, I cannot find this macro on FreeBSD 13. There only
has __FreeBSD__ macro. Is this a typo?

    root@freebsd:~ # uname -a
    FreeBSD freebsd 13.1-RELEASE-p3 FreeBSD 13.1-RELEASE-p3 GENERIC amd64
    root@freebsd:~ # echo | gcc10 -dM -E - | grep -i 'freebsd'
    #define __FreeBSD__ 13


-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

Re: Typo macro name on FreeBSD?

Thomas Munro <thomas.munro@gmail.com> — 2022-12-16T04:25:16Z

On Fri, Dec 16, 2022 at 4:44 PM Japin Li <japinli@hotmail.com> wrote:
> Recently, I compile PostgreSQL on FreeBSD, I find commit a2a8acd152 introduecs
> __freebsd__ macro, however, I cannot find this macro on FreeBSD 13. There only
> has __FreeBSD__ macro. Is this a typo?

Yeah, that seems to be my fault.  Will fix.  Thanks!

Re: Typo macro name on FreeBSD?

Japin Li <japinli@hotmail.com> — 2022-12-16T05:21:59Z

On Fri, 16 Dec 2022 at 12:25, Thomas Munro <thomas.munro@gmail.com> wrote:
> On Fri, Dec 16, 2022 at 4:44 PM Japin Li <japinli@hotmail.com> wrote:
>> Recently, I compile PostgreSQL on FreeBSD, I find commit a2a8acd152 introduecs
>> __freebsd__ macro, however, I cannot find this macro on FreeBSD 13. There only
>> has __FreeBSD__ macro. Is this a typo?
>
> Yeah, that seems to be my fault.  Will fix.  Thanks!

Thanks!

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.