Horton

Re: Identify missing publications from publisher while create/alter subscription.

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Euler Taveira <euler@eulerto.com>, Dilip Kumar <dilipbalaut@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-07T06:02:53Z
Lists: pgsql-hackers 
On Thu, 06 May 2021 at 21:52, vignesh C <vignesh21@gmail.com> wrote:
> On Thu, May 6, 2021 at 9:08 AM Japin Li <japinli@hotmail.com> wrote:
>> 3) Should we free the memory when finish the check_publications()?
>> +       publicationsCopy = list_copy(publications);
>
> I felt this list entries will be deleted in the success case, in error
> case I felt no need to delete it as we will be exiting. Thoughts?
>

Sorry for the noise! You are right. The v9 patch set looks good to me.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

Commits

  1. Raise a WARNING for missing publications.