Horton

Thread

Commits

  1. Remove unnecessary semicolons after goto labels

  1. Remove unnecessary commas for goto labels

    Japin Li <japinli@hotmail.com> — 2022-10-08T23:42:58Z

    Hi hackers,

I find there are some unnecessary commas for goto lables,
attached a patch to remove them.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

  2. Re: Remove unnecessary commas for goto labels

    Julien Rouhaud <rjuju123@gmail.com> — 2022-10-09T03:07:56Z

    Hi,

On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote:
>
> Hi hackers,
>
> I find there are some unnecessary commas for goto lables,
> attached a patch to remove them.

You mean semi-colon?  +1, and a quick regex later I don't see any other
occurrence.

  3. Re: Remove unnecessary commas for goto labels

    Japin Li <japinli@hotmail.com> — 2022-10-09T03:26:27Z

    On Sun, 09 Oct 2022 at 11:07, Julien Rouhaud <rjuju123@gmail.com> wrote:
> Hi,
>
> On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote:
>>
>> Hi hackers,
>>
>> I find there are some unnecessary commas for goto lables,
>> attached a patch to remove them.
>
> You mean semi-colon?  +1, and a quick regex later I don't see any other
> occurrence.

Yeah semi-colon, sorry for the typo.


-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

  4. Re: Remove unnecessary commas for goto labels

    John Naylor <john.naylor@enterprisedb.com> — 2022-10-10T08:18:53Z

    On Sun, Oct 9, 2022 at 10:08 AM Julien Rouhaud <rjuju123@gmail.com> wrote:
>
> Hi,
>
> On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote:
> >
> > Hi hackers,
> >
> > I find there are some unnecessary commas for goto lables,
> > attached a patch to remove them.
>
> You mean semi-colon?  +1, and a quick regex later I don't see any other
> occurrence.

Interestingly, I did find that in C, some statement is needed after a
label, even an empty one, otherwise it won't compile. That's not the case
here, though, so pushed.

--
John Naylor
EDB: http://www.enterprisedb.com

  5. Re: Remove unnecessary commas for goto labels

    Japin Li <japinli@hotmail.com> — 2022-10-10T08:50:17Z

    On Mon, 10 Oct 2022 at 16:18, John Naylor <john.naylor@enterprisedb.com> wrote:
> Interestingly, I did find that in C, some statement is needed after a
> label, even an empty one, otherwise it won't compile.

Yeah, this is required by ISO C [1].

> That's not the case here, though, so pushed.

Thank you!


[1] https://www.gnu.org/software/gnu-c-manual/gnu-c-manual.html#Labels

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.