Horton

Re: file_fdw: Support multi-line HEADER option.

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-01-09T16:14:17Z
Lists: pgsql-hackers 
On Fri, 09 Jan 2026 at 21:57, Shinya Kato <shinya11.kato@gmail.com> wrote:
> On Fri, Jan 9, 2026 at 7:22 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>> > Thoughts?
>>
>> +1
>
> Thank you for the review!
>
>> Could you add this patch to the next Commitfest? It would be better to
>> commit it in v19 so that multi-line header support is delivered for
>> both COPY and file_fdw at the same time.
>
> Yeah, this feature is targeted for v19. I've added it to the next Commitfest.
> https://commitfest.postgresql.org/patch/6383/
>

A minor nitpick:

+  or a numeric line count for <literal>HEADER</literal>) to enable the desired
+  behavior.

s/numeric/non-negative integer/

More precise: excludes negative values & clarifies it's an integer.

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.

Commits

  1. file_fdw: Support multi-line HEADER option.

  2. Improve the error message in COPY with HEADER option.

  3. Support multi-line headers in COPY FROM command.