Horton

Re: Pasword expiration warning

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: Steven Niu <niushiji@gmail.com>
Cc: Yuefei Shi <shiyuefei1004@gmail.com>, Gilles Darold <gilles@darold.net>, songjinzhou <tsinghualucky912@foxmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, "Bossart, Nathan" <bossartn@amazon.com>, Tom Lane <tgl@sss.pgh.pa.us>, liu xiaohui <liuxh.zj.cn@gmail.com>
Date: 2026-01-09T09:04:31Z
Lists: pgsql-hackers

Attachments

Hi, Steven

Thanks for the review.

On Fri, 09 Jan 2026 at 07:36, Steven Niu <niushiji@gmail.com> wrote:
> Hi, Jiapin, 
>
> I reviewed the v9-0002-Add-TAP-test-for-password_expire_warning.patch 
> and here are my comments:
>
> 1. I think we should add tow more cases. One case is for the feature is disbaled. And another is for no warning when >1d remaining.

Add in v10.

> 2. The modification to pg_hba.conf is unnecessary as the default pg_hba.conf generated by initdb already allows local connections with appropriate methods.
>     unlink($node->data_dir . '/pg_hba.conf');
>     $node->append_conf('pg_hba.conf', "local all all scram-sha-256");

Yes, it allows local connections, but they are always in trust mode, so no
password is required (or used).

> 3. Make the expected string to be more exact. 
> qr/your password will expire in/);
> -->
> qr/your password will expire in 1d/);
>

Fixed. PFA.

v10-0001 - No changes.
v10-0002 - Address review comments.

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.

Commits

  1. Add password expiration warnings.