Thread

Re: BUG #19367: typos in backend/utils/adt/timestamp.c

Japin Li <japinli@hotmail.com> — 2025-12-29T10:35:29Z

On Mon, 29 Dec 2025 at 15:55, Rahila Syed <rahilasyed90@gmail.com> wrote:
> Hi,
>
>  There are typos in return type of these functions:
>  1) timestamptz_pl_interval_at_zone(PG_FUNCTION_ARGS)
>      NOW: PG_RETURN_TIMESTAMP(timestamptz_pl_interval_internal(timestamp,
>  span, attimezone));
>      SHOULD:
>  PG_RETURN_TIMESTAMPTZ(timestamptz_pl_interval_internal(timestamp, span,
>  attimezone));
>  2) Datum timestamptz_mi_interval_at_zone(PG_FUNCTION_ARGS)
>      NOW: PG_RETURN_TIMESTAMP(timestamptz_mi_interval_internal(timestamp,
>  span, attimezone));
>      SHOULD:
>  PG_RETURN_TIMESTAMPTZ(timestamptz_mi_interval_internal(timestamp, span,
>  attimezone));
>
> You’re right — these are just typos, and they don’t affect correctness since both 
> ultimately call Int64GetDatum(). 
> Still, +1 for fixing them for clarity.

The functions timestamptz_pl_interval() and timestamptz_mi_interval() have the
same typos, right?

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.