Re: Switching XLog source from archive to streaming when primary available

Japin Li <japinli@hotmail.com>

From: Japin Li <japinli@hotmail.com>

To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

Cc: Ian Lawrence Barwick <barwick@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Cary Huang <cary.huang@highgo.ca>, SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2024-02-19T14:55:43Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add basic TAP tests for the low-level backup method, take two
- 071e3ad59d6f 17.0 cited
Add a failover option to subscriptions.
- 776621a5e479 17.0 cited
Make all Perl warnings fatal
- c5385929593d 17.0 cited
Add PostgreSQL::Test::Cluster::advance_wal
- c161ab74f76a 17.0 cited
Rename wal_keep_segments to wal_keep_size.
- c3fe108c025e 14.0 cited

On Mon, 19 Feb 2024 at 18:36, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
> On Wed, Jan 31, 2024 at 6:30 PM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
>>
>> Needed a rebase due to commit 776621a (conflict in
>> src/test/recovery/meson.build for new TAP test file added). Please
>> find the attached v17 patch.
>
> Strengthened tests a bit by using recovery_min_apply_delay to mimic
> standby spending some time fetching from archive. PSA v18 patch.

Here are some minor comments:

[1]
+        primary). However, the standby exhausts all the WAL present in pg_wal

s|pg_wal|<filename>pg_wal</filename>|g

[2]
+# Ensure checkpoint doesn't come in our way
+$primary->append_conf('postgresql.conf', qq(
+    min_wal_size = 2MB
+    max_wal_size = 1GB
+    checkpoint_timeout = 1h
+	autovacuum = off
+));

Keeping the same indentation might be better.