Horton

Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: Önder Kalacı <onderkalaci@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Etsuro Fujita <etsuro.fujita@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2024-05-23T14:30:18Z
Lists: pgsql-bugs

Attachments

On Thu, 23 May 2024 at 14:54, Önder Kalacı <onderkalaci@gmail.com> wrote:
> Hi Japin,
>
> Thanks, the patch looks good to me.
>
> However, as a non-native English speaker, it might not be accurate.
>> Feel free to modify it.
>>
>>
> I'm also not good at wording, but I have a minor suggestions like the
> following :
>
> /*
>  * Also, the FETCH FIRST/NEXT ... ROW/ROWS WITH TIES clause cannot be
> pushed down
>  * because:
>  * a) The remote system may have a different understanding of equality,
> which can
>  *    result in varying results, such as non-deterministic collations.
>  * b) We do not have knowledge of the remote server's version
>  *    as this clause is only supported for PG13 and above.
>  */
>

Thanks for your review!  Fixed in v5 patch.

--
Regards,
Japin Li

Commits

  1. postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers.

  2. Revert temporal primary keys and foreign keys