Horton

Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: onderkalaci@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2024-05-16T04:02:14Z
Lists: pgsql-bugs

Attachments

On Wed, 15 May 2024 at 17:41, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> Hi Onder,
>
> On Wed, May 15, 2024 at 6:07 PM PG Bug reporting form
> <noreply@postgresql.org> wrote:
>> Hi, it seems the same query with `LimitOption`  on a heap table and on an
>> postgres_fdw table pointing to the same heap table is returning different
>> results.
>
> Thanks for the report!  Will look into this next week, because I am
> busy with something else this week.
>

AppendLimitClause() does not check the limitOption, which may be
LIMIT_OPTION_WITH_TIES. It simply uses the LIMIT clause.

Here is a poc patch to verify the above.

--
Regards,
Japin Li

Commits

  1. postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers.

  2. Revert temporal primary keys and foreign keys