Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption

Japin Li <japinli@hotmail.com>

From: Japin Li <japinli@hotmail.com>

To: Önder Kalacı <onderkalaci@gmail.com>

Cc: Etsuro Fujita <etsuro.fujita@gmail.com>, pgsql-bugs@lists.postgresql.org

Date: 2024-05-16T09:56:46Z

Lists: pgsql-bugs

On Thu, 16 May 2024 at 17:02, Önder Kalacı <onderkalaci@gmail.com> wrote:
> Hi Japin,
>
>>
>>
>> Here is a poc patch to verify the above.
>>
>>
> The patch looks reasonable to me, it is in line with `get_select_query_def()
> <https://github.com/postgres/postgres/blob/8aee330af55d8a759b2b73f5a771d9d34a7b887f/src/backend/utils/adt/ruleutils.c#L5745-L5752>`
> .
>
> Though, probably requires a regression test.
>

Yeah, add the regression test in v2 patch [1].

[1] https://www.postgresql.org/message-id/ME3P282MB31666446BF8A0C0F7A02D24CB6ED2%40ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM

--
Regards,
Japin Li

Commits

postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers.
- 2b461efc5195 13.16 landed
- 269e2c391628 14.13 landed
- b33c141cc52b 15.8 landed
- 8405d5a37a25 16.4 landed
- 8cfbac1492bd 17.0 landed
Revert temporal primary keys and foreign keys
- 8aee330af55d 17.0 cited