Horton

Re: Support ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION ... syntax

Japin Li <japinli@hotmail.com>

View thread View on postgr.es
From: Japin Li <japinli@hotmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-07T02:49:02Z
Lists: pgsql-hackers 
On Tue, 06 Apr 2021 at 17:56, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
> On 06.04.21 07:24, Japin Li wrote:
>>>> I think this patch is about ready to commit, but please provide a final
>>>> version in good time.
>>> I took the liberty to address all the review comments and provide a v9
>>> patch on top of Japin's v8 patch-set.
>>>
>>>> (Also, please combine your patches into a single patch.)
>>> Done.
>>>
>>> Attaching v9 patch, please review it.
>>>
>> Sorry for the late reply! Thanks for your updating the new patch, and it looks
>> good to me.
>
> Committed.
>
> Note that you can use syntax like "ADD|DROP|SET" in the tab completion
> code.  I have simplified some of your code like that.
>
> I also deduplicated the documentation additions a bit.

Thanks!

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

Commits

  1. ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION