Re: Excessive LOG messages from replication slot sync worker

On Tue, Aug 12, 2025 at 10:02:32PM +0900, Fujii Masao wrote:
> On Tue, Aug 12, 2025 at 8:06 PM Japin Li <japinli@hotmail.com> wrote:
> > OTOH, I also update reorder buffer spill file path.
> >
> > $ git grep -E 'xid-.*-lsn.*spill'
> > src/backend/replication/logical/reorderbuffer.c: snprintf(path, MAXPGPATH, "%s/%s/xid-%u-lsn-%X-%X.spill",
> 
> Should we also update LOGICAL_REWRITE_FORMAT to use %08X?
> 
> That said, the number of places to change is growing, and we're drifting
> away from the original issue.... So I started thinking it might be better
> to simply applying Shveta's patch to revert the incorrect format change
> to fix the problem, and then discussing LSN-based filename standardization
> in a separate thread.
> 

Agreed.  See the new thread [1] for a discussion on this.

[1] https://www.postgresql.org/message-id/ME0P300MB0445795E3FF4CA5A1143164FB62AA@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM

-- 
Best regards,
Japin Li
ChengDu WenWu Information Technology Co., LTD.