Re: Option to dump foreign data in pg_dump
Luis Carril <luis.carril@swarm64.com>
From: Luis Carril <luis.carril@swarm64.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Daniel Gustafsson <daniel@yesql.se>, Laurenz Albe <laurenz.albe@cybertec.at>, PostgreSQL
Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-01-29T08:30:16Z
Lists: pgsql-hackers
Thanks for working on the comments. I noticed one behavior is different when --table option is specified. When --table is specified the following are not getting dumped: CREATE SERVER foreign_server I felt the above also should be included as part of the dump when include-foreign-data option is specified. Yes, it also happens on master. A dump of a foreign table using --table, which only dumps the table definition, does not include the extension nor the server. I guess that the idea behind --table is that the table prerequisites should already exist on the database. A similar behavior can be reproduced for a non foreign table. If a table is created in a specific schema, dumping only the table with --table does not dump the schema definition. So I think we do not need to dump the server with the table. Cheers Luis M Carril
Commits
-
pg_dump: Allow dumping data of specific foreign servers
- 2f9eb3132094 13.0 landed