Re: pg_upgrade version checking questions

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Christoph Berg <myon@debian.org>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Tomasz Szypowski <tomasz.szypowski@gmail.com>

Date: 2019-04-04T13:40:40Z

Lists: pgsql-hackers

Attachments

0001-Only-allow-upgrades-by-the-same-exact-version-new-v2.patch (application/octet-stream) patch v2-0001
0002-Check-all-used-executables-v2.patch (application/octet-stream) patch v2-0002
0003-Default-new-bindir-to-exec_path-v2.patch (application/octet-stream) patch v2-0003

On Wednesday, March 27, 2019 1:43 PM, Christoph Berg <myon@debian.org> wrote:

> Re: Daniel Gustafsson 2019-03-26 pC-NMmh4vQLQP76YTwY4AuoD4OdNw9egikekyQpXFpgqmTlGjIZXOTd2W5RDZPpRski5N3ADRrLYgLk6QUuvmuT5fWC9acPAYyDU1AVxJcU=@yesql.se
>
> > 0003 - Make -B default to CWD and remove the exec_path check
> > Defaulting to CWD for the new bindir has the side effect that the default
> > sockdir is in the bin/ directory which may be less optimal.
>
> Hmm, I would have thought that the default for the new bindir is the
> directory where pg_upgrade is located, not the CWD, which is likely to
> be ~postgres or the like?

Yes, thinking on it that's obviously better.  The attached v2 repurposes the
find_my_exec() check to make the current directory of pg_upgrade the default
for new_cluster.bindir (the other two patches are left as they were).

cheers ./daniel

Commits

pg_upgrade: Check version of target cluster binaries
- f06b1c598254 14.0 landed
pg_upgrade: Default new bindir to pg_upgrade location
- 959f6d6a1821 13.0 landed
pg_upgrade: Check all used executables
- 0befb4f31386 13.0 landed