RE: Handle infinite recursion in logical replication setup

Yu Shi (Fujitsu) <shiy.fnst@fujitsu.com>

From: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>

To: vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>

Cc: Peter Smith <smithpb2250@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-05-24T02:36:48Z

Lists: pgsql-hackers

On Tue, May 24, 2022 1:34 AM vignesh C <vignesh21@gmail.com> wrote:
> 
> Thanks for the comments, the attached v15 patch has the fixes for the same.
> 

Thanks for updating the patch. I have a comment on the document in 0002 patch.

@@ -300,6 +310,11 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
           replication from the publisher. The default is
           <literal>false</literal>.
          </para>
+         <para>
+          There is some interaction between the <literal>only_local</literal>
+          option and <literal>copy_data</literal> option. Refer to the
+          <xref linkend="sql-createsubscription-notes" /> for details.
+         </para>
         </listitem>
        </varlistentry>

This change is related to "only_local" option and "copy_data" option, so I think
it should be put together with "only_local", instead of "disable_on_error".

Besides, I tested some cross version cases, pg_dump and describe command, the
results are all as expected.

Regards,
Shi yu

Commits

Improved CREATE SUBSCRIPTION message for clarity
- 1e7ca1189ccc 17.0 landed
- 842b65905046 16.0 landed
Fix the test case introduced by commit 8756930190.
- 032465157347 16.0 landed
Raise a warning if there is a possibility of data from multiple origins.
- 875693019053 16.0 landed
Add wait_for_subscription_sync for TAP tests.
- 0c20dd33db16 16.0 cited
Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.
- 5f858dd3bebd 16.0 cited
Allow users to skip logical replication of data having origin.
- 366283961ac0 16.0 landed
Improve two comments related to a boolean DefElem's value
- 8445f5a21d40 16.0 cited
doc: Fix man page whitespace issues
- d7ab2a9a3c0a 15.0 cited