RE: Column Filtering in Logical Replication

Yu Shi (Fujitsu) <shiy.fnst@fujitsu.com>

From: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>

To: Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>

Cc: vignesh C <vignesh21@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2022-09-05T03:42:40Z

Lists: pgsql-hackers

On Mon, Sep 5, 2022 8:28 AM Peter Smith <smithpb2250@gmail.com> wrote:
> 
> I have rebased the remaining patch (v6-0001 is the same as v5-0002)
> 

Thanks for updating the patch. Here are some comments.

1.
+     the <xref linkend="sql-alterpublication"/> will be successful but later
+     the WalSender on the publisher, or the subscriber may throw an error. In
+     this scenario, the user needs to recreate the subscription after adjusting

Should "WalSender" be changed to "walsender"? I saw "walsender" is used in other
places in the documentation.

2.
+test_pub=# CREATE TABLE t1(id int, a text, b text, c text, d text, e text, PRIMARY KEY(id));
+CREATE TABLE
+test_pub=#

+test_pub=# CREATE PUBLICATION p1 FOR TABLE t1 (id, b, a, d);
+CREATE PUBLICATION
+test_pub=#

I think the redundant "test_pub=#" can be removed.

Besides, I tested the examples in the patch, there's no problem.

Regards,
Shi yu

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Explain about Column List feature.
- f98d07424523 16.0 landed
- 25996a82a446 15.0 landed
Doc: fix column list vs. replica identity rules.
- 376af686111e 16.0 landed
- ab3131880d8a 15.0 landed
Prohibit combining publications with different column lists.
- fd0b9dcebda7 15.0 cited
Fix the check to limit sync workers.
- be46985bed8a 10.21 landed
- a90de822e483 11.16 landed
- 59348fbdeb7b 12.11 landed
- 82d4a17a1750 13.7 landed
- c9dea58e2702 14.3 landed
- dd4ab6fd6528 15.0 landed
Wait for subscription to sync in t/031_column_list.sql
- 404f49338fef 15.0 landed
Move prattrs to the pg_publication_rel section in docs
- 41b00f8e601f 15.0 landed
Allow specifying column lists for logical replication
- 923def9a533a 15.0 landed
Fix row filters with multiple publications
- 5a079662256e 15.0 landed
Fix publish_as_relid with multiple publications
- 27fafee72d17 13.7 landed
- 677a1dc0ca0f 14.3 landed
- c91f71b9dc91 15.0 landed
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 cited
Add index on pg_publication_rel.prpubid
- 025b920a3d45 15.0 landed
Avoid using DefElemAction in AlterPublicationStmt
- 9623d8999603 15.0 landed
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 landed
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 landed
Fix various concurrency issues in logical replication worker launching
- de4389712206 10.0 cited