Horton

RE: pg_recvlogical requires -d but not described on the documentation

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Fujii Masao' <masao.fujii@oss.nttdata.com>, "David G. Johnston" <david.g.johnston@gmail.com>, 'vignesh C' <vignesh21@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-18T07:32:49Z
Lists: pgsql-hackers 
Dear Fujii-san,

Thanks for giving comments and sorry for missing replies.

> I agree that the synopsis doesn't need to be updated. Attached patch clarifies
> the required options for each action in the documentation. Thought?

So, the policy David said is not to modify the synopsis part here, because there
are no rules or it is broken. Instead, we could clarify the mandatory options in
the doc, right?
I have no objections for it.

> BTW, I'm curious why --dbname isn't required for the --drop-slot action.

I'm analyzing around here...

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

  1. Allow pg_recvlogical --drop-slot to work without --dbname.

  2. doc: Clarify required options for each action in pg_recvlogical.

  3. Refactor replication connection code of various pg_basebackup utilities.