RE: Inconsistent GUC descriptions

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

To: 'Kyotaro Horiguchi' <horikyota.ntt@gmail.com>

Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2025-02-20T05:46:17Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Improve errdetail message added by ac0e33136a.
- 7da344b9f84f 18.0 landed
Invalidate inactive replication slots.
- ac0e33136abc 18.0 cited

Dear Horiguchi-san,

I really appreciate your post-commit reviewing.

> However, the existing message for the same situation is written
> without "The value of" at the beginning.

Right. To clarify, max_slot_wal_keep_size has similar check hook which rejects
the upgrade mode, and it starts with "\"%s\" must be set to".

> In addition, all existing
> messages following the "%s must be set to" pattern omit this phrase.

Yes, effective_io_concurrency and maintenance_io_concurrency start with it.

> Therefore, I believe the initial part of the new message should be
> removed for consistency. The attached patch makes this adjustment.

Agreed. I read your patch just in case and looks good to me...

Best regards,
Hayato Kuroda
FUJITSU LIMITED