RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Noboru Saito' <noborusai@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Florents Tselai <florents.tselai@gmail.com>
Date: 2025-06-09T07:17:12Z
Lists: pgsql-hackers
Dear Saito-san,

> - A patch that adds margins to admonition blocks.
> - An updated image where I have highlighted the space with a red
> border for clarity.
> 
> The image shows:
> - The original layout (top left)
> - Only indentation set to 0 (top right)
> - Indentation 0 plus admonition margins (bottom right)

To confirm, the top-right was generated with the previous patch, and bottom-right
was generated v2 patch, right? I prefer the bottom-right one.

BTW, I can suggest separating patches like:

0001 - setting both body.start.indent and body.end.indent to 0
0002 - set margin-left and margin-right to 0.25in

This approach makes us easier to understand and discuss, i.e., someone only loves
0001. They can be combined by committers when they push changes.
To create a series of patches, you can git format-patch command can be used.
Please refer [1] for more detail.


[1]: https://git-scm.com/book/en/v2/Appendix-C:-Git-Commands-Email

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Adjust some table column widths in PDF

  2. Improve PDF documentation margins