RE: Missing program_XXX calling in pgbench tests

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

To: 'Fujii Masao' <masao.fujii@oss.nttdata.com>

Cc: "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>

Date: 2025-06-05T03:00:26Z

Lists: pgsql-hackers

Attachments

v2-0001-pgbench-Run-program_XXX-tests-instead-of-its-own-.patch (application/octet-stream) patch v2-0001
v2-0002-pg_config-add-V-option.patch (application/octet-stream) patch v2-0002
v2-0003-pg_bsd_indent-add-V-option.patch (application/octet-stream) patch v2-0003
v2-0004-Allow-program_XXX_ok-functions-to-test-short-opti.patch (application/octet-stream) patch v2-0004

Dear Fujii-san,

> A bit similar discussion came up before regarding pgbench and program_xxx_ok
> in [1], but it seems that change was never applied.

I didn't know that, thanks for sharing. ISTM, it tried to extend function to test the
shorter options.

While verifying the idea, I found that pg_config and pg_bsd_indent have not been
supported "-V" option yet. They must address the option ro improve test functions.

Attached patch set implemented the idea. 0001 is my original point and can be
backported. 0002-0004 needs API changes so they aim to be applied for HEAD.

If possible, I want to fork another thread to discuss 0002-0004 and want to
concentrate 0001 here.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

pgbench: Use standard option handling test routines
- 3431e3e4aa3a 19 (unreleased) landed