Missing program_XXX calling in pgbench tests
Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>
Date: 2025-06-05T01:18:54Z
Lists: pgsql-hackers
Attachments
- 0001-pgbench-Run-program_XXX-tests-instead-of-its-own-tes.patch (application/octet-stream) patch 0001
Dear hackers, While reviewing another thread I found #SUBJECT. Most of client program executes program_help_ok, program_version_ok, program_options_handling_ok() in their test, but pgbench does not do. Instead pgbench has own tests for --help and --version options. One concern is that program_help_ok() checks whether lines are too long or not. For now, the rule seems to be kept but not sure in future. I feel that we can replace tests with common function, like attached. How do you think? Best regards, Hayato Kuroda FUJITSU LIMITED
Commits
-
pgbench: Use standard option handling test routines
- 3431e3e4aa3a 19 (unreleased) landed