RE: Selectively invalidate caches in pgoutput module

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

To: 'Amit Kapila' <amit.kapila16@gmail.com>

Cc: Andres Freund <andres@anarazel.de>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "ShlokKumar.Kyal@fujitsu.com" <ShlokKumar.Kyal@fujitsu.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>

Date: 2025-03-28T05:16:29Z

Lists: pgsql-hackers

Attachments

0001-Stablize-tests-added-in-3abe9dc188.patch (application/octet-stream) patch 0001

Dear Amit,

> The problem here is that after ALTER SUBSCRIPTION tap_sub SET
> PUBLICATION ..., we didn't wait for the new walsender on publisher to
> start. We must use wait_for_subscription_sync both after the "CREATE
> SUBSCRIPTION ..." and the "ALTER SUBSCRIPTION ..." commands and keep
> copy_data=true to ensure the initial replication is setup between
> publisher and subscriber. This is how we use these commands at other
> places.

Agreed. PSA the patch to fix the issue.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

Avoid invalidating all RelationSyncCache entries on publication rename.
- 3abe9dc18892 18.0 landed
Avoid invalidating all RelationSyncCache entries on publication change.
- 588acf6d0ec1 18.0 landed