Horton

RE: Missing program_XXX calling in pgbench tests

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Fujii Masao' <masao.fujii@oss.nttdata.com>, 'Peter Eisentraut' <peter@eisentraut.org>
Cc: "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>
Date: 2025-06-09T04:48:33Z
Lists: pgsql-hackers

Attachments

Dear Fujii-san,

> I agree with Peter. I don't think patches 0002 and 0003 are necessary.
> 
> As for 0004, it adds tests for the short options -? and -V, which
> duplicate the existing tests for the long options --help and --version.
> I'm not sure it's worth adding tests just to confirm that the short
> and long options behave the same.

Only adding 0004 is not allowed because it can fail due to other commands.
So let's drop them.

I verified 0001 can be applied cleanly for all supported branches. To clarify,
let me attach the 0001 patch again. Please focus on it...

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

  1. pgbench: Use standard option handling test routines