RE: Disabled logical replication origin session causes primary key errors

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

To: 'Masahiko Sawada' <sawada.mshk@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Shawn McCoy <shawn.the.mccoy@gmail.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, "drewwcallahan@gmail.com" <drewwcallahan@gmail.com>, "scott@meads.us" <scott@meads.us>

Date: 2025-04-22T09:06:20Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix an oversight in 3f28b2fcac.
- 0e091ce409e0 18.0 landed
- 05676d87e2e6 17.5 landed
- 0de091a4b585 16.9 landed
Don't advance origin during apply failure.
- 3f28b2fcac33 18.0 cited

Attachments

v4-HEAD-0001-Fix-oversight-3f28b2f.patch (application/octet-stream) patch v4-0001
v4-PG16-17-0001-Fix-oversight-3f28b2f.patch (application/octet-stream) patch v4-0001

Dear Sawada-san,

> Thank you for the patch. The changes look reasonable to me. Can we add
> some regression tests for that?
>

Yeah it should be added. I think it is enough to add the first scenario. Done in
100_bugs.pl.
I also ran pgindent/pgperltidy. Because of self-reviewing the version became v4.

Best regards,
Hayato Kuroda
FUJITSU LIMITED