RE: Improve error reporting for few options in pg_createsubscriber
Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'vignesh C' <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-25T03:18:00Z
Lists: pgsql-hackers
Dear Vignesh, > Currently, error reports for database, publication, subscription, and > replication slots do not include the option name. This has been > addressed by including the option name in the error messages, ensuring > consistency similar to remove option. Confirmed all error reporting in switch have its option name. > Additionally, pg_log_error and > exit(1) have been replaced with a single pg_fatal statement which > means the same. The attached patch implements these changes. I grepped source and confirmed that exit(1) just after pg_log_error() does not exist anymore. Several lines have below style, but IIUC it is out-of-scope of the patch. pg_log_error(); pg_log_error_hint(); exit(1); Best regards, Hayato Kuroda FUJITSU LIMITED
Commits
-
pg_createsubscriber: Improve error messages.
- 898c131b58a0 18.0 landed