RE: [Proposal] Add accumulated statistics

Yoshikazu Imai (Fujitsu) <imai.yoshikazu@fujitsu.com>

From: "imai.yoshikazu@fujitsu.com" <imai.yoshikazu@fujitsu.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Robert Haas <robertmhaas@gmail.com>, "yotsunaga.naoki@fujitsu.com" <yotsunaga.naoki@fujitsu.com>, Bruce Momjian <bruce@momjian.us>, Phil Florent <philflorent@hotmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2019-12-19T06:05:22Z

Lists: pgsql-hackers

Attachments

0001-Adding-the-pg_stat_waitaccum-view-which-shows-counts-v3.patch (application/octet-stream) patch v3-0001
0002-POC-Changed-measuring-method-of-wait-event-timed-fro-v3.patch (application/octet-stream) patch v3-0002

On Sun, Dec 1, 2019 at 1:10 AM, Michael Paquier wrote:
> On Wed, Oct 30, 2019 at 05:55:28AM +0000, imai(dot)yoshikazu(at)fujitsu(dot)com wrote:
> > And here is the patch which counts the wait event and measuring the wait event time. It is currently like POC and has several things to be improved.
> 
> Please note the patch tester complains about the latest patch:
> pgstatfuncs.c: In function ‘pg_stat_get_waitaccum’:
> pgstatfuncs.c:2018:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
> Datum  values[PG_STAT_GET_WAITACCUM_COLS]; 
> 
> I am moving it to next CF, marking it as waiting on author.

Sorry for late reply.

Unfortunately, I couldn't get your original mail even if I used "Resend email"
on pgsql-hackers archive, that I reply to my old mail.

I attach the patch I solved the warning.

--
Yoshikazu Imai