RE: invalid data in file backup_label problem on windows

wangsh.fnst@fujitsu.com <wangsh.fnst@fujitsu.com>

From: "wangsh.fnst@fujitsu.com" <wangsh.fnst@fujitsu.com>
To: David Steele <david@pgmasters.net>, Magnus Hagander <magnus@hagander.net>, Andrew Dunstan <andrew@dunslane.net>
Cc: Michael Paquier <michael@paquier.xyz>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-28T12:53:09Z
Lists: pgsql-hackers
Hi,

David Steele <david@pgmasters.net> wrote:
>On 3/26/21 1:20 PM, Magnus Hagander wrote:
>> On Fri, Mar 26, 2021 at 5:52 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>>> On 3/26/21 10:19 AM, David Steele wrote:
>>>>
>>>>> No, the problem is you are using copy/paste and in doing so you are
>>>>> *changing'* the value that is being returned. You'll either need to
>>>>> update your copy/paste procedure to not mess with the newlines, or to
>>>>> use a better way to get the data out.
>>>>>
>>>>> If we need to clarify that in the documentation, I'm fine with that.
>>>>> Maybe add an extra sentence to the part about not modifying the output
>>>>> to mention that this includes changing newslines and also encoding
>>>>> (which would also break it, if you managed to find a non-ascii
>>>>> compatible encoding). Maybe even something along the line of "the
>>>>> contents have to be written in binary mode"?
>>>>
>>>> Perhaps something like the attached?
>>>
>>> That seems a bit opaque.  Let's tell them exactly what they need to avoid.
>> 
>> Yeah, it seems a bit imprecise. Maybe something like "which includes
>> things like opening the file in binary mode"? (I want the "includes"
>> part because it also means other things, this is not the only thing).
>
>OK, how about the attached?

I think this is good for me to avoid this problem.
And next time I will use libpq and fopen(xxx, "wb") to create this file.
Thanks

Best regards
Shenhao Wang

Commits

  1. doc: Clarify how to generate backup files with non-exclusive backups