Horton

RE: [PATCH] pgbench: improve \sleep meta command

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es
From: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
To: 'Fujii Masao' <masao.fujii@oss.nttdata.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: 'miyake_kouta' <miyake_kouta@oss.nttdata.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-17T07:40:30Z
Lists: pgsql-hackers 
Dear Fujii-san,

Thank you for updating the patch.
I understand that you don't want to change the current specification.

```diff
+               if (usec == 0)
+               {
+                       char       *c = var;
+
+                       /* Skip sign */
+                       if (*c == '+' || *c == '-')
+                               c++;
```

In my understanding the skip is not necessary, because
plus sign is already removed in the executeMetaCommand() and minus value can be returned by atoi().


Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

  1. pgbench: Improve error-handling in \sleep command.