RE: Data is copied twice when specifying both child and parent table in publication
Wei Wang (Fujitsu) <wangw.fnst@fujitsu.com>
From: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
To: Andres Freund <andres@anarazel.de>
Cc: vignesh C <vignesh21@gmail.com>, Peter Smith <smithpb2250@gmail.com>, "Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Amit Langote <amitlangote09@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>, Greg Nancarrow <gregn4422@gmail.com>
Date: 2023-02-08T03:51:08Z
Lists: pgsql-hackers
Attachments
- HEAD_v16-0001-Fix-data-replicated-twice-when-specifying-publis.patch (application/octet-stream) patch v16-0001
- HEAD_v16-0002-Add-clarification-for-the-behaviour-of-the-publi.patch (application/octet-stream) patch v16-0002
- REL15_v16-0001-Fix-data-replicated-twice-when-specifying-publis_patch (application/octet-stream)
- REL14_v16-0001-Fix-data-replicated-twice-when-specifying-publis_patch (application/octet-stream)
On Wed, Feb 8, 2023 4:29 AM Andres Freund <andres@anarazel.de> wrote:
> Hi,
>
> On 2022-11-16 08:58:31 +0000, wangw.fnst@fujitsu.com wrote:
> > Attach the new patch set.
>
> This patch causes several of the tests to fail. See e.g.:
>
> https://cirrus-ci.com/task/6587624765259776
>
> Most of the failures appear to be due to the main regression tests failing:
> https://api.cirrus-
> ci.com/v1/artifact/task/6587624765259776/testrun/build/testrun/regress/regres
> s/regression.diffs
>
> diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/publication.out
> /tmp/cirrus-ci-build/build/testrun/regress/regress/results/publication.out
> --- /tmp/cirrus-ci-build/src/test/regress/expected/publication.out 2023-02-
> 07 20:19:34.318018729 +0000
> +++ /tmp/cirrus-ci-build/build/testrun/regress/regress/results/publication.out
> 2023-02-07 20:22:53.545223026 +0000
> @@ -1657,7 +1657,7 @@
> SELECT * FROM pg_publication_tables;
> pubname | schemaname | tablename | attnames | rowfilter
> ---------+------------+------------+----------+-----------
> - pub | sch2 | tbl1_part1 | {a} |
> + pub | sch2 | tbl1_part1 | |
> (1 row)
>
> DROP PUBLICATION pub;
Thanks for your kind reminder and analysis.
I think this failure is caused by the recently commit (b7ae039) in the current
HEAD. Rebased the patch set and attach them.
Regards,
Wang Wei
Commits
-
Avoid syncing data twice for the 'publish_via_partition_root' option.
- 062a84442424 16.0 landed
-
Fix partition table's REPLICA IDENTITY checking on the subscriber.
- 52d5ea9adb01 14.5 cited
-
Prohibit combining publications with different column lists.
- fd0b9dcebda7 15.0 cited
-
Fix double publish of child table's data.
- 3f06c00cf6dc 13.6 landed
- 614b77d65a38 14.2 landed
- 5e97905a2c76 15.0 landed
-
Support adding partitioned tables to publication
- 17b9e7f9fe23 13.0 cited