Horton

RE: Confused comment about drop replica identity index

Wei Wang (Fujitsu) <wangw.fnst@fujitsu.com>

View thread View on postgr.es
From: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-21T01:31:42Z
Lists: pgsql-hackers 
On Tue, Dec 20, 2021 at 19:11PM, Michael Paquier wrote:
> That's mostly fine.  I have made some adjustments as per the attached.

Thanks for reviewing.


> +         The default for non-system tables. Records the old values of the columns
> +         of the primary key, if any. The default for non-system tables.
> The same sentence is repeated twice.
> 
> +         Records no information about the old row.(This is the
> default for system tables.)
> For consistency with the rest, this could drop the parenthesis for the second
> sentence.
> 
> +       <term><literal>USING INDEX index_name</literal></term>
> This should use <replaceable> as markup for index_name.

The change looks good to me.



Regards,
Wang wei

Commits

  1. Correct comment and some documentation about REPLICA_IDENTITY_INDEX

  2. Add regression tests for REPLICA IDENTITY with dropped indexes