Horton

RE: row filtering for logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread
From: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Euler Taveira <euler@eulerto.com>, Greg Nancarrow <gregn4422@gmail.com>, vignesh C <vignesh21@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Önder Kalacı <onderkalaci@gmail.com>, japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>, David Steele <david@pgmasters.net>, Craig Ringer <craig@2ndquadrant.com>, Amit Langote <amitlangote09@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-07T04:37:58Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Release cache tuple when no longer needed

  2. Add some additional tests for row filters in logical replication.

  3. Fix one of the tests introduced in commit 52e4f0cd47.

  4. Allow specifying row filters for logical replication of tables.

  5. Move scanint8() to numutils.c

  6. Replace Test::More plans with done_testing

  7. Reduce relcache access in WAL sender streaming logical changes

  8. Small cleanups related to PUBLICATION framework code

  9. Add a view to show the stats of subscription workers.

  10. Allow publishing the tables of schema.

  11. Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.

  12. Add PublicationTable and PublicationRelInfo structs

  13. Remove unused argument "txn" in maybe_send_schema().

  14. Add prepare API support for streaming transactions in logical replication.

  15. Unify PostgresNode's new() and get_new_node() methods

  16. Use l*_node() family of functions where appropriate

  17. Add support for prepared transactions to built-in logical replication.

  18. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.

  19. Rename a parse node to be more general

  20. Remove unused column atttypmod from initial tablesync query

  21. SEARCH and CYCLE clauses

Attachments

On Sat, Feb 5, 2022 7:51 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Fri, Feb 4, 2022 at 2:58 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
> wrote:
> >
> > On Thursday, February 3, 2022 11:11 PM houzj.fnst@fujitsu.com
> > <houzj.fnst@fujitsu.com>
> >
> > Since the v76-0000-clean-up-pgoutput-cache-invalidation.patch has been
> > committed, attach a new version patch set to make the cfbot happy.
> > Also addressed the above comments related to tab-complete in 0002 patch.
> >
> 
> I don't like some of the error message changes in this new version. For example:
> 
> v75:
> +CREATE FUNCTION testpub_rf_func1(integer, integer) RETURNS boolean AS
> $$ SELECT hashint4($1) > $2 $$ LANGUAGE SQL;
> +CREATE OPERATOR =#> (PROCEDURE = testpub_rf_func1, LEFTARG = integer,
> RIGHTARG = integer);
> +CREATE PUBLICATION testpub6 FOR TABLE testpub_rf_tbl3 WHERE (e =#> 27);
> +ERROR:  invalid publication WHERE expression for relation "testpub_rf_tbl3"
> +DETAIL:  User-defined operators are not allowed.
> 
> v77
> +CREATE FUNCTION testpub_rf_func1(integer, integer) RETURNS boolean AS
> $$ SELECT hashint4($1) > $2 $$ LANGUAGE SQL;
> +CREATE OPERATOR =#> (PROCEDURE = testpub_rf_func1, LEFTARG = integer,
> RIGHTARG = integer);
> +CREATE PUBLICATION testpub6 FOR TABLE testpub_rf_tbl3 WHERE (e =#> 27);
> +ERROR:  invalid publication WHERE expression LINE 1: ...ICATION
> +testpub6 FOR TABLE testpub_rf_tbl3 WHERE (e =#> 27);
> +                                                             ^
> +DETAIL:  User-defined or mutable functions are not allowed
> 
> I think the detailed message by v75 "DETAIL:  User-defined operators are not
> allowed." will be easier for users to understand. I have made some code changes
> and refactoring to make this behavior like previous without removing the
> additional checks you have added in v77. I have made a few changes to
> comments and error messages. Attached is a top-up patch on your v77 patch
> series. I suggest we can combine the
> 0001 and 0002 patches as well.

Thanks for the comments.
Your changes look good to me.

Attach the V78 patch which addressed the above changes and merged 0001 and
0002.

Best regards,
Hou zj