Horton

RE: [PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist

tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>

View thread View on postgr.es
From: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-19T05:10:07Z
Lists: pgsql-hackers 
On Thursday, August 19, 2021 12:28 PM, Michael Paquier <michael@paquier.xyz> wrote
>On Wed, Aug 18, 2021 at 10:04:04AM +0900, Michael Paquier wrote:
>> Yes, that does not seem wise on performance grounds.  The case of
>> !zero_is_valid is never reached, so it seems like this code was just a
>> copy-paste from the float code in the backend.  Your patch looks right
>> to me.
>
>Applied.

Thanks for you check and commit, I've changed the patch's commit fest status to 'committed'.
https://commitfest.postgresql.org/34/3287/

Regards,
Tang

Commits

  1. Improve performance of float overflow checks in btree_gist

  2. Provide separate header file for built-in float types