Horton

[Doc] Tiny fix for regression tests example

tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>

View thread View on postgr.es
From: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>, "peter@eisentraut.org" <peter@eisentraut.org>, Craig Ringer <craig.ringer@2ndquadrant.com>
Date: 2021-07-23T06:12:02Z
Lists: pgsql-hackers, pgsql-docs

Attachments

Hi



When reading PG DOC, found some example code not correct as it said.

https://www.postgresql.org/docs/devel/regress-run.html



Here's a tiny fix in regress.sgml.



-make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB"

+make check PGOPTIONS="-c geqo=off -c work_mem=50MB"



log_checkpoints couldn't be set in PGOPTIONS.

Replace log_checkpoints with geqo in the example code.



-make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf"

+make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf"



User needs to specify $(pwd) to let the command execute as expected.



The above example code is added by Peter in PG14. So I think we need to apply this fix at PG14/master.

I proposed this fix at pgsql-docs@lists.postgresql.org<mailto:pgsql-docs@lists.postgresql.org> at [1]. But no reply except Craig. So I please allow me to post the patch at Hackers’ mail list again in case the fix is missed.



[1] https://www.postgresql.org/message-id/OS0PR01MB6113FA937648B8F7A372359BFB009%40OS0PR01MB6113.jpnprd01.prod.outlook.com



Regards,

Tang

Commits

  1. doc: Fix command example to run regression tests with PGOPTIONS