Horton

[PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist

tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>

View thread View on postgr.es
From: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-06T14:14:21Z
Lists: pgsql-hackers

Attachments

Hi

Commit 6bf0bc842 replaced float.c's CHECKFLOATVAL() macro with static inline subroutines, 
but the fix introduced a performance regression as Tom Lane pointed out and fixed at 607f8ce74.

Found obsolete CHECKFLOATVAL usage in contrib/btree_gist, and tried to fix it according to 607f8ce74.
The attached patch has been testified in master. All tap tests passed.

Regards,
Tang

Commits

  1. Improve performance of float overflow checks in btree_gist

  2. Provide separate header file for built-in float types