Horton

RE: Remove "FROM" in "DELETE FROM" when using tab-completion

tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>

View thread View on postgr.es
From: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-05-11T09:33:05Z
Lists: pgsql-hackers

Attachments

On Tuesday, May 11, 2021 5:44 PM, Dilip Kumar <dilipbalaut@gmail.com> wrote:
>But your patch is doing nothing to add the implementation for DELETE..
>USING.  Basically, the tab completion support for DELETE....USING is
>still pending right?

I see, maybe I have a misunderstanding here, I thought tab completion for "DELETE....USING" means the code before it as follows.
> >    else if (TailMatches("DELETE", "FROM", MatchAny))
> >            COMPLETE_WITH("USING", "WHERE");

So I just thought the tab completion support for DELETE....USING is not pending anymore.
According to your feedback, maybe something beyond my knowledge is need to be done for DELETE....USING.

Besides, you are right, the fix in the patch has nothing to do with the comment here.
Patch updated to V2 with the sentence moved back. Thanks.

Regards,
Tang

Commits

  1. Make saner the tab completion of INSERT and DELETE in psql

  2. psql tab completion improvements, from Greg Sabino Mullane: