RE: Support tab completion for upper character inputs in psql

tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>

From: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Japin Li <japinli@hotmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, "smithpb2250@gmail.com" <smithpb2250@gmail.com>, "david.zhang@highgo.ca" <david.zhang@highgo.ca>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2022-07-22T08:30:48Z

Lists: pgsql-hackers

Attachments

v1-0001-fix-memory-leak-in-tab-completion.c.patch (application/octet-stream) patch v1-0001

On Monday, January 31, 2022 3:35 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com> writes:
> > Thanks for your V16 patch, I tested it.
> > The results LGTM.
> 
> Pushed, thanks for looking.

I think 02b8048 forgot to free some used memory. 
Attached a tiny patch to fix it. Please have a check.

Regards,
Tang

Commits

Fix minor memory leaks in psql's tab completion.
- 90474c16a7d2 16.0 landed
- 00cf40328a31 15.0 landed
Further tweaks for psql's new tab-completion logic.
- f0cd9097cfac 15.0 landed
Treat case of tab-completion keywords a bit more carefully.
- 020258fbd30d 15.0 landed
psql: improve tab-complete's handling of variant SQL names.
- 02b8048ba5dc 15.0 landed
Make PQcancel use the PGconn's tcp_user_timeout and keepalives settings.
- 5987feb70b5b 15.0 cited
Use a WaitLatch for vacuum/autovacuum sleeping
- 4753ef37e0ed 14.0 cited